New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-6883: Introduce ArchUnit test for membership #3748
GEODE-6883: Introduce ArchUnit test for membership #3748
Conversation
Using ArchUnit to write a test that membership classes must only depend on other membership classes. Co-Authored-By: Bill Burcham <bburcham@pivotal.io> Co-Authored-By: Ernest Burghardt <eburghardt@pivotal.io> Co-Authored-By: Dan Smith <dsmith@pivotal.io>
@bschuchardt, @echobravopapa @pivotal-jbarrett please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of using ArchUnit both as a way to verify architecture requirements and as a checklist of future work on membership modularization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good Bill - nice addition to our tests
|
||
.or(not(resideInAPackage("org.apache.geode.."))) | ||
|
||
// TODO: Create a new stats interface for membership |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated booooooooooooo!
I hope you haven't opened JIRA tickets for these TODO
s, because no one is looking here for work to do.
Using ArchUnit to write a test that membership classes must only
depend on other membership classes.
Co-Authored-By: Bill Burcham bburcham@pivotal.io
Co-Authored-By: Ernest Burghardt eburghardt@pivotal.io
Co-Authored-By: Dan Smith dsmith@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.