Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/GEODE-7130: rollback the timed out and expired transaction. #3973

Merged
merged 1 commit into from Aug 27, 2019

Conversation

pivotal-eshu
Copy link
Contributor

No description provided.

@@ -754,7 +754,7 @@ void cleanGlobalTransactionMap(List tranxns) {
}
}

void removeTranxnMappings(List tranxns) {
void removeTranxnMappingsAndRollbackExpiredTransaction(List tranxns) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have a unit test for this.

Copy link
Contributor

@jhuynh1 jhuynh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, if a transaction times out, we don't automatically roll it back?

@pivotal-eshu
Copy link
Contributor Author

Regular geode transactions are cleaned up (similar to rollback) after time out.

This is Geode JTA transaction manager implementation which does not handle timed out global transaction correctly. Third part JTA transaction manager may handle this correctly.

@pivotal-eshu pivotal-eshu merged commit 6cbd679 into develop Aug 27, 2019
@pivotal-eshu pivotal-eshu deleted the feature/GEODE-7130 branch January 22, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants