New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-6871: Disk free space info exposed via JMX #4067
Conversation
...e/src/integrationTest/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
...e/src/integrationTest/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
@Test | ||
public void givenDiskStoreIsCreatedWithDefaultSize_thenGetDiskUsagePercentageShouldNotBeAvailable() | ||
public void givenDiskStoreIsCreatedWithDefaultSize_thenDiskPercentagesShouldNotBeAvailable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're already modifying the test name, can you please remove the underscores and use camel case instead?.
...e/src/integrationTest/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
...e/src/integrationTest/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
...e/src/integrationTest/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/management/DiskStoreMXBean.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/management/DiskStoreMXBean.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright to me, I appreciate the descriptive test names!
Its better to use descriptive names than comments explaining the test case :) Thanks! |
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.