GEODE-6985: Implement RestrictedMethodAuthorizer #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed minor warnings. - Made the class final, immutable and thread safe. - Added comprehensive javadocs to all public methods. - Added several unit tests for the class and all public methods. - Added methods 'isAllowedGeodeMethod' and 'isKnownDangerousMethod'.
…due to shiro static contexts.
jhuynh1
approved these changes
Sep 23, 2019
| if (cache instanceof InternalCache) { | ||
| // Use the already created SecurityService. | ||
| this.securityService = ((InternalCache) cache).getSecurityService(); | ||
| } else { |
There was a problem hiding this comment.
Out of curiosity, when does this branch get invoked?
There was a problem hiding this comment.
Never in theory, but users or application frameworks might have a wrapper around our cache, I think it's better to have the extra check and create the security service from the properties instead of failing with a ClassCastException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.