GEODE-7258: Pulling the failing test while fixing #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhansonp
changed the title
kirklund
requested changes
Oct 2, 2019
| @@ -31,7 +29,7 @@ | |||
| public class RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated | |||
| extends LuceneSearchWithRollingUpgradeDUnit { | |||
|
|
|||
| @Test | |||
| // @Test | |||
There was a problem hiding this comment.
Actually, add @Ignore and just leave @Test in place. You co do something like:
@Ignore("Disabled until GEODE-7258 is fixed")
And then add a note to GEODE-7258 to re-enable this test.
There was a problem hiding this comment.
Done. I like that better.
kirklund
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEODE-7258: Pulling a test while it is fixed.