GEODE-7184: Add function execution timers #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add micrometer timers for recording function executions - Refactor FunctionStats and FunctionServiceStats Co-authored-by: Aaron Lindsey <alindsey@pivotal.io> Co-authored-by: Kirk Lund <klund@apache.org> Co-authored-by: Dale Emery <demery@pivotal.io> Co-authored-by: Mark Hanson <mhanson@pivotal.io>
- Change static fields to instance fields on FunctionStatsManager - Mark static field as @immutable on NoopMeterRegistry Authored-by: Aaron Lindsey <alindsey@pivotal.io>
- Remove unused/unnecessary code - Fix warnings Authored-by: Aaron Lindsey <alindsey@pivotal.io>
aaronlindsey
commented
Oct 9, 2019
...core/src/main/java/org/apache/geode/internal/cache/execute/ServerRegionFunctionExecutor.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java
Outdated
Show resolved
Hide resolved
kirklund
requested review from
jake-at-work,
kirklund,
demery-pivotal,
mhansonp,
jhuynh1 and
boglesby
added 2 commits
October 9, 2019 11:27
Authored-by: Aaron Lindsey <alindsey@pivotal.io>
- Broken by refactor in previous commit Authored-by: Aaron Lindsey <alindsey@pivotal.io>
kirklund
approved these changes
Oct 11, 2019
mhansonp
approved these changes
Oct 11, 2019
...re/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java
Outdated
Show resolved
Hide resolved
jhuynh1
reviewed
Oct 14, 2019
...core/src/main/java/org/apache/geode/internal/cache/execute/metrics/FunctionServiceStats.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java
Outdated
Show resolved
Hide resolved
jhuynh1
approved these changes
Oct 15, 2019
- Rename FunctionServiceStats.endFunctionExecutionWithElapsedTime to distinguish it from FunctionStats.endFunctionExecution which takes a start time. - Remove extra call to FunctionStats.getTime() in MemberFunctionStreamingMessage and add boolean to prevent calling endFunctionExecutionWithException before startFunctionExecution was called. Authored-by: Aaron Lindsey <alindsey@pivotal.io>
aaronlindsey
commented
Oct 17, 2019
Functions with hasResult()=false execute asynchronously on an executor. Previously, the instrumentation code recorded a successful function execution after submitting a function to an executor, which is incorrect because the function has not necessarily executed at that point. Now, we record the execution time only after the function actually executes. Co-authored-by: Aaron Lindsey <alindsey@pivotal.io> Co-authored-by: Kirk Lund <klund@apache.org>
Authored-by: Aaron Lindsey <alindsey@pivotal.io>
I believe this issue is fixed. See comment. |
kirklund
requested changes
Oct 18, 2019
...Test/java/org/apache/geode/metrics/function/executions/FunctionExecutionsTimerLonerTest.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/cache/execute/ServerFunctionExecutor.java
Outdated
Show resolved
Hide resolved
- Remove FunctionStats.getTime() in favor of returning the time from FunctionStats.startFunctionExecution() - Add static import for assertj Assertions Authored-by: Aaron Lindsey <alindsey@pivotal.io>
kirklund
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Aaron Lindsey alindsey@pivotal.io
Co-authored-by: Kirk Lund klund@apache.org
Co-authored-by: Dale Emery demery@pivotal.io
Co-authored-by: Mark Hanson mhanson@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.