GEODE-7407: Remove AttributesFactory (4/4) #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one the commits to remove the deprecated 'AttributesFactory' class from the geode-assembly module. The work is splitted to avoid hitting issues in CI. - Fixed some minor warnings. - Replaced usages of 'junit.Assert' by 'assertj'.
jujoramos
changed the title
jujoramos
changed the title
agingade
approved these changes
Nov 8, 2019
| InternalDistributedSystem ds = InternalDistributedSystem.getConnectedInstance(); | ||
| invocationCount++; | ||
| ArrayList<String> l = (ArrayList<String>) context.getArguments(); | ||
| if (l != null) { | ||
| assertFalse(Collections.disjoint(l, ds.getDistributedMember().getGroups())); | ||
| assertThat(Collections.disjoint(l, ds.getDistributedMember().getGroups())).isFalse(); |
There was a problem hiding this comment.
I am unable to see; the changes in this PR having any relation to attributes factory removal.
Anyways the change looks good.
There was a problem hiding this comment.
@agingade : thanks for reviewing and approving this!.
Long story short: there was a single PR with 2 commits: one removing usages of AttributesFactory and the other one fixing warnings, removing usages of other deprecated classes and replacing junit.Assert by assert4j.
Due to issues while running StressNewTest with 4 test files changed, I had to split the single PR in 4 (one for each test class), that's the only reason why the name doesn't match, I'll make sure to put something more meaningful while doing the squash and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one the commits to remove the deprecated 'AttributesFactory'
class from the geode-assembly module. The work is splitted to avoid
hitting issues in CI.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.