New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-6994: OQL Add Method Invocation Security Docs #4325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. I mostly just have some typo/grammar fixes and wording change suggestions.
geode-docs/developing/query_select/the_where_clause.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/developing/query_select/the_where_clause.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
geode-docs/managing/security/method_invocation_authorizers.html.md.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed some minor changes to the PR, addressing a bit of punctuation and wording improvements. Thanks for all the PR changes. It looks good to me!
- Added 'build-docs-output.txt' to list of git ignored files. - Fixed the 'Authorization Overview' page to reflect new directory layout and removed deprecated examples. - Added example to illustrrate how the 'MethodInvocationAuthorizer' can be used to implement a custom authorization mechanism. - Added comprehensive documentation about the OQL Method Invocation Security feature, pros and cons, how it can it customized and configured, etcetera.
…fault and grammar contractions.
… are running in the cluster.
26405b1
to
cbba941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a few typos - approved.
Thanks @davebarnes97!. |
- Added 'build-docs-output.txt' to list of git ignored files. - Fixed the 'Authorization Overview' page to reflect new directory layout and removed deprecated examples. - Added example to illustrate how the 'MethodInvocationAuthorizer' can be used to implement a custom authorization mechanism. - Added comprehensive documentation about the OQL Method Invocation Security feature, pros and cons, how it can it customized and configured, etcetera. - Added warning note about changing the authorizer when CQs are running in the cluster.
layout and removed deprecated examples.
can be used to implement a custom authorization mechanism.
Security feature, pros and cons, how it can it customized and
configured, etcetera.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.