Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7568: Pass persistence service to config mgr constructors #4462

Merged
merged 2 commits into from Dec 11, 2019

Conversation

demery-pivotal
Copy link
Contributor

@demery-pivotal demery-pivotal commented Dec 11, 2019

Pass the persistence service to each manager on construction, rather
than passing it to each method.

Co-authored-by: Dale Emery demery@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@jmelchio Please review

Pass the persistence service to each manager on construction, rather
than passing it to each method.

Co-authored-by: Dale Emery <demery@pivotal.io>
Copy link
Member

@jinmeiliao jinmeiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, this is good. Later on when want to allow other modules to add in their own configuraiton/manager/realizers, so this map needs to be dynamically loaded by service loaders (or other registration mechanism), then we need to inject persistenceService into them, probably will need to add a setter in the ConfigurationManager to set the persistence service instead of using a constructor parameter.

@demery-pivotal demery-pivotal merged commit 6ed908b into apache:develop Dec 11, 2019
@demery-pivotal demery-pivotal deleted the GEODE-7568 branch December 11, 2019 17:34
davebarnes97 pushed a commit to davebarnes97/geode that referenced this pull request Jan 22, 2020
…he#4462)

* GEODE-7568: Pass persistence service to config mgr constructors

Pass the persistence service to each manager on construction, rather
than passing it to each method.

Co-authored-by: Dale Emery <demery@pivotal.io>

* Remove spurious commented code
mhansonp pushed a commit to mhansonp/geode that referenced this pull request Mar 12, 2020
…he#4462)

* GEODE-7568: Pass persistence service to config mgr constructors

Pass the persistence service to each manager on construction, rather
than passing it to each method.

Co-authored-by: Dale Emery <demery@pivotal.io>

* Remove spurious commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants