GEODE-7626: Break dependency on LocalViewMessage in membership #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalViewMessage was a DistributionMessage executed in an executor owned by ClusterDistributionmanager. This arrangement was very convoluted because CDM only had upstream involvement in membership view installation. This PR moves view installation into GMSMembership using a single-threaded executor similar to what CDM used but without statistics. Stats for the view installation thread have never been useful so I have not retained that functionality. There are already many tests for view installation, so while I've modified a couple I haven't added any new tests.
...e-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMembership.java
Outdated
Show resolved
Hide resolved
echobravopapa
approved these changes
Dec 27, 2019
upthewaterspout
approved these changes
Dec 27, 2019
...e-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMembership.java
Show resolved
Hide resolved
...e-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMembership.java
Show resolved
Hide resolved
davebarnes97
pushed a commit
to davebarnes97/geode
that referenced
this pull request
Jan 22, 2020
…e#4538) * GEODE-7626: Break dependency on LocalViewMessage in membership LocalViewMessage was a DistributionMessage executed in an executor owned by ClusterDistributionmanager. This arrangement was very convoluted because CDM only had upstream involvement in membership view installation. This PR moves view installation into GMSMembership using a single-threaded executor similar to what CDM used but without statistics. Stats for the view installation thread have never been useful so I have not retained that functionality. There are already many tests for view installation, so while I've modified a couple I haven't added any new tests. * make constructor private * simplifying the executor
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 12, 2020
…e#4538) * GEODE-7626: Break dependency on LocalViewMessage in membership LocalViewMessage was a DistributionMessage executed in an executor owned by ClusterDistributionmanager. This arrangement was very convoluted because CDM only had upstream involvement in membership view installation. This PR moves view installation into GMSMembership using a single-threaded executor similar to what CDM used but without statistics. Stats for the view installation thread have never been useful so I have not retained that functionality. There are already many tests for view installation, so while I've modified a couple I haven't added any new tests. * make constructor private * simplifying the executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalViewMessage was a DistributionMessage executed in an executor owned
by ClusterDistributionmanager. This arrangement was very convoluted
because CDM only had upstream involvement in membership view
installation.
This PR moves view installation into GMSMembership using a
single-threaded executor similar to what CDM used but without
statistics. Stats for the view installation thread have never been
useful so I have not retained that functionality.
There are already many tests for view installation, so while I've
modified a couple I haven't added any new tests.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.