Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7919: Moving membership integration test to geode-membership #4862

Conversation

upthewaterspout
Copy link
Contributor

Moving MembershipOnlyTest to MembershipIntegrationTest in the geode-membership
module and adding some more tests.

Moving MembershipOnlyTest to MembershipIntegrationTest in the geode-membership
module and adding some more tests.
Copy link
Contributor

@Bill Bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as-is. I made a couple suggestions for improvement, which you can take or leave :)

Copy link
Contributor

@bschuchardt bschuchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice set of tests. I have one suggestion

@upthewaterspout upthewaterspout merged commit 4966e50 into apache:develop Mar 30, 2020
@upthewaterspout upthewaterspout deleted the feature/basic-membership-integration-GEODE-7919 branch March 30, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants