GEODE-254: Removed deprecated Region.keys and Region.entries #488
Conversation
|
This looks good. Pull it in. |
| @@ -187,7 +187,7 @@ public void destroyRegion(Object callbackArgument) throws CacheWriterException, | |||
| public Set entries(boolean recursive) { | |||
There was a problem hiding this comment.
I think it is wrong to keep these methods your are removing from Region on classes that implement the Region interface. It is too bad that these impls did not have @OverRide on them because that would have caused compilation failures.
There was a problem hiding this comment.
AdminRegion was another class that implements Region that should be updated to no longer impl the methods you are removing. You should look at all the classes that implement Region.
| @@ -388,7 +388,7 @@ public Set keySetOnServer() { | |||
| public Set keys() { | |||
There was a problem hiding this comment.
I think you want this old "keys()" implementation to now be "keySet()". The old "keySet" did not properly call preOp/postOp.
| @@ -321,7 +321,7 @@ public void destroyRegion(Object aCallbackArgument) | |||
| } | |||
|
|
|||
| public Set entries(boolean recursive) { | |||
There was a problem hiding this comment.
Another example of a method that should no longer exist since it is no longer on Region
| @@ -1702,6 +1702,8 @@ public Set entrySet(boolean recursive) { | |||
| return entries(recursive); | |||
| } | |||
|
|
|||
| public abstract Set entries(boolean recursive); | |||
There was a problem hiding this comment.
Why add this abstract method when you are getting rid of entries(boolean)?
|
Thanks @dschneider-pivotal for review. I will fix those issue and raise another PR, as this one is already merged. |
Replacing all inststance of entries with entrySet
Replacing all inststance of entries with entrySet GEODE-254: Fixing the Test Failures - Removed test testIndexMaintenanceWithIndexOnMethodEntries since this is no more applicable. GEODE-254: Spotless fixing.
…stance of entries with entrySet GEODE-254: Fixing the Test Failures - Removed test testIndexMaintenanceWithIndexOnMethodEntries since this is no more applicable. GEODE-254: Spotless fixing. This closes #504 Signed-off-by: adongre <adongre@apache.org>
No description provided.