Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7905, GEODE-7870: Ignore flaky tests while they are being worked on #4887

Merged

Conversation

jdeppe-pivotal
Copy link
Contributor

Authored-by: Jens Deppe jdeppe@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

…d on

Authored-by: Jens Deppe <jdeppe@pivotal.io>
@mkevo
Copy link
Contributor

mkevo commented Mar 31, 2020

I think that you set wrong ticket number in commit message, it should be GEODE-7905.

@jdeppe-pivotal
Copy link
Contributor Author

Thanks for the review! Yes I did mis-type the ticket number - glad you picked that up :)

@jdeppe-pivotal jdeppe-pivotal merged commit 0320dc1 into apache:develop Mar 31, 2020
@jdeppe-pivotal jdeppe-pivotal changed the title GEODE-7904, GEODE-7870: Ignore flaky tests while they are being worked on GEODE-7905, GEODE-7870: Ignore flaky tests while they are being worked on Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants