New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-7852: SNI extension support #4920
Conversation
Modified SNISocketFactory so it can be used in cache.xml Added a test for the new cache.xml element. Updated docs for cache.xml and updated client configuration instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @bschuchardt. I saw a couple minor things…
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIAcceptanceTest.java
Show resolved
Hide resolved
geode-docs/topologies_and_comm/cs_configuration/setting_up_a_client_server_system.html.md.erb
Show resolved
Hide resolved
geode-dunit/src/main/java/org/apache/geode/test/dunit/internal/ProcessManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending a green CI run...
geode-docs/topologies_and_comm/cs_configuration/setting_up_a_client_server_system.html.md.erb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw one small formatting typo and made a couple suggestions about consistency tweaks…
geode-docs/topologies_and_comm/cs_configuration/setting_up_a_client_server_system.html.md.erb
Show resolved
Hide resolved
geode-docs/topologies_and_comm/cs_configuration/setting_up_a_client_server_system.html.md.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
… code needs some of this stuff
Modified SNISocketFactory so it can be used in cache.xml
Added a test for the new cache.xml element.
Updated docs for cache.xml and updated client configuration
instructions.
Please point me at any other docs that should be updated or suggestions for new sections.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.