GEODE-8025: fix lucene test to not hang on support branches #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dickcav
approved these changes
Apr 26, 2020
onichols-pivotal
deleted the
GEODE-8025-fix-lucene-test-to-not-hang-on-support-branches
branch
onichols-pivotal
added a commit
that referenced
this pull request
Apr 26, 2020
(cherry picked from commit fad52b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Lucene upgrade test is aimed at old versions that are incompatible with the current version. The test assumed that ALL old versions are incompatible. However on a support branch, the current could be 1.12.1 and the "old" version could be 1.12.0, which are compatible.
To avoid hangs, skip this test when the minors are the same, since that is not the intended precondition for the test.