Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: GEODE-8040: Make BootstrappingFunction unit testable #5033

Conversation

kirklund
Copy link
Contributor

No description provided.

@kirklund kirklund force-pushed the GEODE-8040-BootstrappingFunctionIntegrationTest branch from 2530749 to 37c6e89 Compare May 6, 2020 18:40
@kirklund
Copy link
Contributor Author

kirklund commented May 6, 2020

@jdeppe-pivotal do you have any ideas why any changes to BootstrappingFunction causes the Tomcat session tests in UpgradeTest to fail? I only made changes to BootstrappingFunction to enable it to be well unit tested, but after a week I still can't get it to pass. I'm reluctant to throw away the changes but I'm out of time. I moved BootstrappingFunctionTest to BootstrappingFunctionIntegrationTest because it creates a full Cache despite the use of Mockito. The when/thenReturn stubbing for the BootstrappingFunction spy is incorrect -- the test executes the real code and THEN returns the mockCache -- but the real code creates a real Cache that then isn't used.

@kirklund kirklund closed this May 14, 2020
@kirklund kirklund deleted the GEODE-8040-BootstrappingFunctionIntegrationTest branch April 8, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant