GEODE-7707: Tab completing '--url' on 'connect' gives two default values #5061
Conversation
|
@moleske as you wrote the ticket, could you review this PR? I think it also needs @davebarnes97 review because documentation is impacted. |
There was a problem hiding this comment.
Thanks for doing this! The only question I have is more of @davebarnes97 question, but welcome your thoughts also! We can also probably just merge as is if we want
geode-docs/tools_modules/gfsh/command-pages/connect.html.md.erb
Outdated
Show resolved
Hide resolved
| @@ -193,8 +193,8 @@ http://myLocatorHost.example.com:8080/gemfire/v1 | |||
| "Locator could not find a JMX Manager"; | |||
| "jmx password must be specified."; | |||
| "Could not connect to : {0}. {1}"; | |||
| "Could not find a GemFire jmx-manager service running at {0}."; | |||
| "Could not find a Geode jmx-manager service running at {0}."; | |||
There was a problem hiding this comment.
I have changed lines 196 & 199 to show how these strings really look (they are defined in CliStrings.java)
There was a problem hiding this comment.
@alb3rtobr @moleske +1 good catch.
| @@ -175,16 +175,16 @@ gfsh>connect | |||
| ``` pre | |||
| gfsh>connect | |||
| Connecting to Locator at [host=localhost, port=10334] .. | |||
| Connecting to Manager at [host=GemFireStymon, port=1099] .. | |||
| Successfully connected to: [host=GemFireStymon, port=1099] | |||
| Connecting to Manager at [host=GeodeStymon, port=1099] .. | |||
There was a problem hiding this comment.
Lines 178 & 179 are just host names, but as they are the only referece left to "GemFire" I changed it to "Geode"
|
The ApiCheckTestOpenJDK11 is a new job that is failing on all PRs. Merging this is as since there's open JIRA for fixing Api Check |
this PR aligns the command help and documentation with the code, there is no default value for
--urlparameter.Command help will look as follows: