GEODE-231 : Remove deprecated AttributesMutator.setCacheListener #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed setCacheListener method from AttributesMutator and AbstractRegion. Changed tests to use either initCacheListeners or addCacheListener methods from AttributesMutator.
Spotlessapply changes
Removed commented test
|
+1 Looks good , only fix conflicts. |
| @@ -14,19 +14,18 @@ | |||
| */ | |||
| package org.apache.geode.test.junit.rules; | |||
|
|
|||
| import java.util.EnumSet; | |||
| import java.util.Set; | |||
There was a problem hiding this comment.
I see no reason why this import reorg should be part of this pull request.
|
+1 |
|
Thanks @ameybarve15 @dschneider-pivotal for review. |
dschneider-pivotal
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed AttributesMutator.setCacheListener from AttributesMutator interface and AbstractRegion.
Modified tests to use addCacheListener/initCacheListener.
Removed tests which are not valid for new APIs
Changed references in java docs.