Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-8140: scope field in gfsh create RR regions. #5126

Closed
wants to merge 1 commit into from

Conversation

nabarunnag
Copy link
Contributor

* create region now includes a new field called scope to set the scope
* This field is only valid for Replicated Regions.
* describe region for replicated regions will now display the scope too.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

	* create region now includes a new field called scope to set the scope
	* This field is only valid for Replicated Regions.
	* describe region for replicated regions will now display the scope too.
@nabarunnag nabarunnag added this to In progress in Applications API via automation May 16, 2020
@davebarnes97
Copy link
Contributor

If I'm reading the code correctly, this feature affects two gfsh commands, create region and describe region. It will impact the user guide, at minimum, in the descriptions of those two commands, and possible in a gfsh usage section. Please address these documentation tasks -- if not in this JIRA/PR pair, then in a separate JIRA/PR pair. Thank you.

@onichols-pivotal
Copy link
Contributor

this PR appears to be abandoned, can it be closed?

@onichols-pivotal
Copy link
Contributor

closed due to lack of activity

Applications API automation moved this from In progress to Done Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants