GEODE-6070: Fix ShutdownCommandOverHttpDUnitTest flakiness

[kirklund]

Use IgnoredException for DistributedSystemDisconnectedException.

[jchen21]

Is it preferable to use withFailMessage than as for this case?

[kirklund]

I use as to indicate an alias for the subject of the assertion, and withFailMessage as a full replacement of the failure message.

distributed system isConnected is probably a better example of English for an as in this case. It's kind of interesting to compare the output when using as vs withFailMessage.

Using as:

org.junit.ComparisonFailure: [cache.getDistributedSystem().isConnected()] 
Expected :false
Actual   :true
 <Click to see difference>


	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at org.apache.geode.test.awaitility.WithFailMessageTest.foo(WithFailMessageTest.java:79)

Using withFailMessage:

java.lang.AssertionError: cache.getDistributedSystem().isConnected()

	at org.apache.geode.test.awaitility.WithFailMessageTest.foo(WithFailMessageTest.java:79)

So I only use withFailMessage if I want to actually suppress and replace the native assertion failure message.

[kirklund]

And this is the same assertion failure without as or withFailMessage:

org.junit.ComparisonFailure: 
Expected :false
Actual   :true
 <Click to see difference>


	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at org.apache.geode.test.awaitility.WithFailMessageTest.foo(WithFailMessageTest.java:78)

[jchen21]

Thank you for the explanation and examples!