Further rework of the RestoreRedundancy data objects for serialization #5281
Conversation
|
This code is to fix another serialization issue with the Restore Redundancy code. Basically, it is very painful from what I have seen to json deserialize a Duration object type. So I have converted the field to a long. |
| totalPrimaryTransferTime = | ||
| totalPrimaryTransferTime.plusMillis(details.getPrimaryTransferTime()); | ||
| totalPrimaryTransferTime + details.getPrimaryTransferTime(); |
There was a problem hiding this comment.
This could be replaced with totalPrimaryTransferTime += details.getPrimaryTransferTime();
| } | ||
|
|
||
| @Test | ||
| public void testSerializable() throws JsonProcessingException { |
There was a problem hiding this comment.
This test sets multiple fields but does not verify all of them. Would it be possible to confirm that all data in the object is correctly serialized and deserialized, not just the message and status fields?
There was a problem hiding this comment.
done. assertThat(value).isEqualToComparingFieldByField(restoreRedundancyResults);
| totalPrimaryTransferTime = | ||
| totalPrimaryTransferTime.plus(results.getTotalPrimaryTransferTime()); | ||
| totalPrimaryTransferTime + results.getTotalPrimaryTransferTime(); |
There was a problem hiding this comment.
This can be replaced with totalPrimaryTransferTime += results.getTotalPrimaryTransferTime();
| restoreRedundancyResults.addRegionResult(regionRedundancyStatus); | ||
| String jsonString = geodeMapper.writeValueAsString(restoreRedundancyResults); | ||
| // deserialize the class | ||
| RestoreRedundancyResultsImpl value = |
There was a problem hiding this comment.
you can use assertJ's isEqualToComparingFieldByField method to compare all the fields are the same
There was a problem hiding this comment.
did you forget to push your commit?
There was a problem hiding this comment.
Nope it is failing... It doesn't like the objects in the satisfiedregion lists.
There was a problem hiding this comment.
assertThat(value).usingRecursiveComparison().isEqualTo(restoreRedundancyResults);
worked
jinmeiliao
changed the title
…erialization (apache#5281) * Converting a Duration to a Long because of Serialization * Changes for per requests
looking for errors.