GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT" #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
| // for the first field | ||
| gfsh>create lucene index --name=indexName --region=/orders | ||
| --field=customer,tags --analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer | ||
| --field=customer,tags --analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer | ||
| ``` | ||
| To use the entire value as a single field set the required `--field` |
There was a problem hiding this comment.
Add a comma between "field" and "set"
There was a problem hiding this comment.
The sentence that needs the comma has been completely rewritten for GEODE-3002. See PR #550 for the rewrite. Not implementing, as it would only cause a conflict upon merging in GEODE-3002.
There was a problem hiding this comment.
Cool. LGTM, then. +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DivineEnder @nabarunnag @ladyVader @boglesby @joeymcallister @davebarnes97
Please review.