Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-7864: Always true check removed. #5485

Closed
wants to merge 1 commit into from
Closed

GEODE-7864: Always true check removed. #5485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ void waitForViewInstallation(long id) throws InterruptedException {
return;
}
synchronized (membershipViewIdGuard) {
while (membershipViewIdAcknowledged < id && !stopper.isCancelInProgress()) {
while (!stopper.isCancelInProgress()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this LGTM alert is incorrect, since it fails to take into account the value of membershipViewIdAcknowledged being modified by another thread, which seems to be what this method expects to happen. This false positive alert has been suppressed in this PR: #5473 to prevent it from showing up in future.

if (logger.isDebugEnabled()) {
logger.debug("waiting for view {}. Current DM view processed by all listeners is {}", id,
membershipViewIdAcknowledged);
Expand Down