GEODE-8495: Make tests honor default disk dir property #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testClientSubscriptionQueueUsingDefaultDS() test in CacheXml66DUnitTest and its subclasses assumed that the system’s default disk directory is the JVM’s current working directory. This change removes that assumption by making the tests honor the defaultDiskDirs system property. Authored-by: Dale Emery <demery@vmware.com>
demery-pivotal
requested review from
gesterzhou,
jchen21,
kirklund,
jinmeiliao,
agingade and
mhansonp
jinmeiliao
approved these changes
Oct 1, 2020
mhansonp
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testClientSubscriptionQueueUsingDefaultDS() test in
CacheXml66DUnitTest and its subclasses assumed that the system’s default
disk directory is the JVM’s current working directory.
This change removes that assumption by making the tests honor the
defaultDiskDirs system property.
Authored-by: Dale Emery demery@vmware.com