GEODE-8293: fix activeCQCount has negative value after close/stop cq for PR #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karensmolermiller
requested changes
Oct 14, 2020
|
Can you improve the commit message for this PR? It should include a description of what was actually changed and why it fixes the issue. Thanks! |
mkevo
changed the title
|
I don't have permission to modify your PR.
"The quantity reported for partitioned regions may be larger than that of replicated regions, as each redundant copy contributes the the count."
Thank you for your patience on completing this PR. |
karensmolermiller
approved these changes
Nov 2, 2020
kohlmu-pivotal
previously requested changes
Nov 3, 2020
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Show resolved
Hide resolved
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java
Outdated
Show resolved
Hide resolved
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
Outdated
Show resolved
Hide resolved
kohlmu-pivotal
moved this from Changes Requested
to Verified - Approved
in Quality Review
|
Hi @kohlmu-pivotal , |
agingade
approved these changes
Nov 11, 2020
|
All changes requested are done and PR is approved, I will merge this PR. |
mkevo
dismissed
kohlmu-pivotal’s stale review
All changes are done and waiting for response for a long time
mkevo
added a commit
to Nordix/geode
that referenced
this pull request
Nov 17, 2020
alb3rtobr
pushed a commit
to Nordix/geode
that referenced
this pull request
Aug 2, 2021
alb3rtobr
pushed a commit
to Nordix/geode
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For partitioned regions if the CQ is registered on one server, it will be created on all the nodes/servers hosting the region.
In this case activeCQCount is increment only on one server.
After close/stop CQ it found that it has CQ on all members and decrement num of active CQs, despite of that it is only incremented on one server, so we got negative values.
With fix it will increment activeCQCount on all nodes/servers that hosting the region. So when it close/stop it will not go to the negative values.
This change will not have effects on non-partitioned(replicated) regions.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.