GEODE-3021: Any call after the first to setPdxStringFlag should no-op #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The flag isIndexedPdxKeysFlagSet is now checked before setting pdx string flag
|
@boglesby @upthewaterspout @gesterzhou |
nabarunnag
approved these changes
Jun 8, 2017
kirklund
reviewed
Jun 9, 2017
| @@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object outerEntries, Object innerEntries | |||
| */ | |||
| synchronized void setPdxStringFlag(Object key) { | |||
| // For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet flag | |||
| if (key == null || key == IndexManager.NULL || key == QueryService.UNDEFINED) { | |||
| if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL | |||
There was a problem hiding this comment.
Looks like you have two flags for the same thing... isIndexedPdxKeys and isIndexedPdxKeysFlagSet?
There was a problem hiding this comment.
They are slightly different. The isIndexedPdxKeys is represents whether the index is storing pdx as keys. The isIndexedPdxKeysFlagSet, is a boolean that is used as a short circuit to only call the method once. I guess it was a performance "enhancement" to not call the method over and over for every value and just call it only for the first call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nabarunnag @ladyVader
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.