Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-3044: User Manual: Update Swagger example and screen shots #566

Closed
wants to merge 2 commits into from

Conversation

davebarnes97
Copy link
Contributor

Updates Swagger screen shots and the example command lines that create the screens.

Request reviews from @karensmolermiller and @jaredjstewart. Thanks!

@jaredjstewart
Copy link
Contributor

I think it would probably be best to omit --J=-Dgemfire.http-service-bind-address=localhost from the start server command for the sake of simplicity. You also might want to consider changing /Users/dbarnes/apache-geode-1.2.0/locator1 to something more generic like /Users/admin/apache-geode-1.2.0/locator1 in the command output. Looks good otherwise!

Copy link
Contributor

@karensmolermiller karensmolermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with 2 suggested changes:

  1. Anonymize your name out of the sample gfsh command in step (1)
  2. The prose at the beginning of step (2) has two colons. Please revise to have one colon.

@jaredjstewart
Copy link
Contributor

Some more feedback after walking through the example.. Now that we start a locator (which starts an http server of its own on 7070) we need to specify a different http port for the server to use. Here is the command that I ended up using:

start server --name=server1 --start-rest-api --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true --J=-Dgemfire.http-service-port=8080

@jaredjstewart
Copy link
Contributor

(I also need to file a bug since that command appeared to hang.. But it did end up starting the server despite gfsh hanging with an endless ".....")

@asfgit asfgit closed this in 8c1bf9e Jun 6, 2017
asfgit pushed a commit that referenced this pull request Jun 6, 2017
@davebarnes97 davebarnes97 deleted the feature/GEODE-3044 branch June 6, 2017 22:04
asfgit pushed a commit that referenced this pull request Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants