GEODE-8647: Support multiple instances of DistributedMap #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirklund
force-pushed
the
GEODE-8647-DistributedMap-multiple
branch
from
f074233
to
0da61e9
Compare
Includes additional improvements for usage of DistributedMap.
kirklund
force-pushed
the
GEODE-8647-DistributedMap-multiple
branch
from
0da61e9
to
e859149
Compare
DonalEvans
reviewed
Oct 27, 2020
Comment on lines
+624
to
+630
| distributedMap1.put("key1", "value1"); | ||
|
|
||
| map2.set(distributedMap2.map()); | ||
| distributedMap2.put("key2", "value2"); | ||
|
|
||
| map3.set(distributedMap3.map()); | ||
| distributedMap3.put("key3", "value3"); |
There was a problem hiding this comment.
Might it be worth extracting the hardcoded string keys/values in this test class to constants?
kohlmu-pivotal
approved these changes
Oct 27, 2020
kohlmu-pivotal
moved this from Awaiting Triage
to Verified - Approved
in Quality Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: #5664 should be merged before this PR.