Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-3042: Quick doc of new string-based partition resolver #572

Closed

Conversation

karensmolermiller
Copy link
Contributor

@dschneider-pivotal @davebarnes97 @pivotal-eshu @joeymcallister and all of the Geode community: Please review this PR with world-record speed, as it is likely the last item holding up making a 1.2 release candidate.

Copy link
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Copy link
Contributor

@pivotal-eshu pivotal-eshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I am not sure if the additional information (like Exception will be thrown if configured default StringPrefixPartitionResolver but key does not contains the delimiter.) could be included in the docs.

@karensmolermiller
Copy link
Contributor Author

Thanks Dave and Eric. I've created https://issues.apache.org/jira/browse/GEODE-3063 to address further documentation for this new feature. I'm going to merge this in.

@asfgit asfgit closed this in 8c41fd3 Jun 9, 2017
asfgit pushed a commit that referenced this pull request Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants