Suggest nominations based on commit history #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version of the code owners file with no owners filled in. This just breaks the code down into different areas that might want owners.
To allow some components to be unowned, remove the default owner.
* Add writers to CODEOWNERS
This reverts commit e5b9330.
onichols-pivotal
requested review from
Bill,
boglesby,
kirklund,
metatype,
jake-at-work,
PurelyApplied,
bschuchardt,
gesterzhou,
pivotal-eshu,
dschneider-pivotal,
jinmeiliao,
DonalEvans,
echobravopapa,
mhansonp and
BenjaminPerryRoss
nabarunnag
approved these changes
Dec 16, 2020
DonalEvans
approved these changes
Dec 16, 2020
jchen21
approved these changes
Jan 7, 2021
onichols-pivotal
requested review from
agingade,
jchen21,
nabarunnag,
rhoughton-pivot and
upthewaterspout
upthewaterspout
approved these changes
Jan 7, 2021
jchen21
approved these changes
Jan 7, 2021
bschuchardt
approved these changes
Jan 7, 2021
echobravopapa
approved these changes
Jan 7, 2021
sabbey37
approved these changes
Jan 7, 2021
boglesby
approved these changes
Jan 7, 2021
BenjaminPerryRoss
approved these changes
Jan 7, 2021
dschneider-pivotal
requested changes
Jan 7, 2021
agingade
approved these changes
Jan 8, 2021
dschneider-pivotal
approved these changes
Jan 8, 2021
gesterzhou
approved these changes
Jan 8, 2021
rhoughton-pivot
approved these changes
Jan 8, 2021
kirklund
previously requested changes
Jan 8, 2021
There was a problem hiding this comment.
The nominations for persistence don't seem quite right: @kirklund @dschneider-pivotal @jchen21
For example, I've never studied or touched the persistence code. I think the best candidate reviewers for persistence code should be @upthewaterspout and @gesterzhou.
pivotal-amurmann
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the self-nomination process we still had a few gaps. I've reviewed past commit history to suggest a couple names for each remaining area.
As per dev list discussion, review period for this PR will be extended to 3pm Friday Jan 8. At that time, anyone that has not explicitly consented to their nomination (by approving this PR) will be removed (and if this leaves any code areas with fewer than 2 owners, the remaining owner will be cleared as well).