New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-5922: concurrency problems in SerialGatewaySenderQueue #5870
GEODE-5922: concurrency problems in SerialGatewaySenderQueue #5870
Conversation
reverting 3ed37a7 for performance testing
return false; | ||
} finally { | ||
lock.writeLock().unlock(); | ||
public synchronized boolean put(Object event) throws CacheException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we having testing around this now synchronized
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any code changes for usage of this method...
if (!isExtraPeeked) { | ||
boolean wasEmpty = this.lastDispatchedKey == this.lastDestroyedKey; | ||
if (!isExtraPeeked) { | ||
this.lastDispatchedKey = key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask why this was re-ordered, but its just the diff making it look that way...
reverting 3ed37a7, which caused enqueuing time for async queues to triple.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.