Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-8920: Modify debug logging to make it easier to trace a message #6041

Merged
merged 1 commit into from Feb 22, 2021

Conversation

kamilla1201
Copy link
Contributor

@kamilla1201 kamilla1201 commented Feb 19, 2021

This PR changes the debug log messages to include the uniqueId of each outgoing Connection.

Before connections are formed, DirectChannel.sendToMany prints out a message and the destinations:

[debug 2021/02/18 17:00:07.408 CST peergemfire_2_3_host1_69611 <vm_7_thr_17_peer_2_3_host1_69611> tid=0x139] Sending (CloseCacheMessage@65a3824f processorId=11477 sender=192.168.1.74(peergemfire_2_3_host1_69611:69611)<ec><v1>:41005 (processorId=11477)) to 2 peers ([192.168.1.74(peergemfire_2_2_host1_69609:69609)<ec><v2>:41007, 192.168.1.74(peergemfire_2_1_host1_69607:69607)<ec><v1>:41003]) via tcp/ip

After connections are formed, it prints them out, including the uids:
[debug 2021/02/18 17:00:07.408 CST peergemfire_2_3_host1_69611 <vm_7_thr_17_peer_2_3_host1_69611> tid=0x139] Sending on these 2 connections: [192.168.1.74(peergemfire_2_2_host1_69609:69609)<ec><v2>:41007(uid=153), 192.168.1.74(peergemfire_2_1_host1_69607:69607)<ec><v1>:41003(uid=154)]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@kamilla1201 kamilla1201 marked this pull request as ready for review February 19, 2021 16:14
Copy link
Contributor

@bschuchardt bschuchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a game changer in tracking messages between servers. Now we can identify the exact thread that should receive a message by looking at the sending Connection's "uid" and the "uid" in the name of the receiving Thread.

@bschuchardt bschuchardt merged commit fc2fc9f into apache:develop Feb 22, 2021
kamilla1201 added a commit to kamilla1201/geode that referenced this pull request Mar 1, 2021
Bill pushed a commit that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants