Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-8859: fix redis-compatability data structure bucket memory-usag… #6084

Conversation

jhutchison
Copy link
Contributor

…e reporting

-implement default getForceReCalculateSize in RedisData interface
-expose dataStoreBytesInUse on GeodeRedisServer
-expose dataStoreBytesInUse on GeodeRedisService
-expose dataStoreBytesInUse on RedisClusterStartupRule

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

…e reporting

-implement default getForceReCalculateSize in RedisData interface
-expose dataStoreBytesInUse on GeodeRedisServer
-expose dataStoreBytesInUse on GeodeRedisService
-expose dataStoreBytesInUse on RedisClusterStartupRule
@jhutchison jhutchison force-pushed the GEODE_8859_fix_redis_data_structure_bucket_size_reporting branch from e68ac2d to 82b8d03 Compare March 3, 2021 21:46
@sabbey37 sabbey37 added the redis Issues related to the geode-for-redis module label Mar 5, 2021
Copy link
Contributor

@dschneider-pivotal dschneider-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two of your new files are missing the copyright header. That is why rat is failing in the build

@jhutchison jhutchison requested a review from sabbey37 March 5, 2021 20:55
Copy link
Contributor

@upthewaterspout upthewaterspout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. At some point we need to implement Sizeable for RedisData, but I think this should work for now.

@jdeppe-pivotal jdeppe-pivotal merged commit e927bdf into apache:develop Mar 8, 2021
jhutchison added a commit to jhutchison/geode that referenced this pull request Mar 10, 2021
…e reporting (apache#6084)

- Implement default getForceReCalculateSize in RedisData interface
- Expose dataStoreBytesInUse on GeodeRedisServer
- Expose dataStoreBytesInUse on GeodeRedisService
- Expose dataStoreBytesInUse on RedisClusterStartupRule

Authored-by: john Hutchison <hutchisonjo@vmware.com>
nabarunnag added a commit to nabarunnag/geode that referenced this pull request Apr 3, 2021
nabarunnag added a commit to nabarunnag/geode that referenced this pull request Apr 3, 2021
nabarunnag added a commit that referenced this pull request Apr 5, 2021
nabarunnag added a commit to nabarunnag/geode that referenced this pull request Apr 5, 2021
…ory-usage reporting (apache#6084)" (apache#6260)

This reverts commit e927bdf.

(cherry picked from commit 7a85b4d)
nabarunnag added a commit that referenced this pull request Apr 6, 2021
…ory-usage reporting (#6084)" (#6260) (#6269)

This reverts commit e927bdf.

(cherry picked from commit 7a85b4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis Issues related to the geode-for-redis module
Projects
None yet
5 participants