-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-8859: fix redis-compatability data structure bucket memory-usag… #6084
GEODE-8859: fix redis-compatability data structure bucket memory-usag… #6084
Conversation
…e reporting -implement default getForceReCalculateSize in RedisData interface -expose dataStoreBytesInUse on GeodeRedisServer -expose dataStoreBytesInUse on GeodeRedisService -expose dataStoreBytesInUse on RedisClusterStartupRule
e68ac2d
to
82b8d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two of your new files are missing the copyright header. That is why rat is failing in the build
geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/BucketSizeTest.java
Outdated
Show resolved
Hide resolved
...stributedTest/java/org/apache/geode/redis/internal/data/ParitionedRegionStatsUpdateTest.java
Outdated
Show resolved
Hide resolved
...stributedTest/java/org/apache/geode/redis/internal/data/ParitionedRegionStatsUpdateTest.java
Outdated
Show resolved
Hide resolved
...stributedTest/java/org/apache/geode/redis/internal/data/ParitionedRegionStatsUpdateTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. At some point we need to implement Sizeable for RedisData, but I think this should work for now.
…e reporting (apache#6084) - Implement default getForceReCalculateSize in RedisData interface - Expose dataStoreBytesInUse on GeodeRedisServer - Expose dataStoreBytesInUse on GeodeRedisService - Expose dataStoreBytesInUse on RedisClusterStartupRule Authored-by: john Hutchison <hutchisonjo@vmware.com>
…ory-usage reporting (apache#6084)" This reverts commit e927bdf.
…ory-usage reporting (apache#6084)" This reverts commit e927bdf.
…ory-usage reporting (apache#6084)" (apache#6260) This reverts commit e927bdf. (cherry picked from commit 7a85b4d)
…e reporting
-implement default getForceReCalculateSize in RedisData interface
-expose dataStoreBytesInUse on GeodeRedisServer
-expose dataStoreBytesInUse on GeodeRedisService
-expose dataStoreBytesInUse on RedisClusterStartupRule
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.