GEODE-9002: Add New Statistic Type For /proc/schedstat #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill
changed the title
|
This PR has been untouched for several months, can it be closed? |
|
closing as abandoned |
Bill
commented
Mar 11, 2024
| @@ -1118,6 +1119,10 @@ private void forceDisconnect(String reason) { | |||
| joinResponse.notifyAll(); | |||
| } | |||
| } else { | |||
|
|
|||
| // TODO: consider either always doing this or putting it behind a system property flag | |||
| OSProcess.printStacks(0); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEODE-9002
This feature is almost complete. Gathering of the new
LinuxThreadSchedulerstatistics type (onStatisticsinstance per CPU) is currently enabled by default. The next step is to disable it by default and only enable it if TBD system property is set.See ticket for details.
This PR also has code to print stack when the member receives forced-disconnect. If we leave that code in it needs to be turned off by default and enabled via a system property.
TODO
LinuxThreadSchedulerstatistic type by default, enable via system propertyFor all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?