GEODE:9009 finish support for functionality compatible with Redis DEC… #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhutchison
requested review from
jdeppe-pivotal,
nonbinaryprogrammer and
sabbey37
as code owners
jdeppe-pivotal
approved these changes
Mar 12, 2021
...Test/java/org/apache/geode/redis/internal/executor/string/AbstractDecrByIntegrationTest.java
Outdated
Show resolved
Hide resolved
sabbey37
requested changes
Mar 12, 2021
There was a problem hiding this comment.
One additional scenario that would be good to add to the integration tests is when a key is already set to the Long.MIN_VALUE and we try to DECRBY 1. It should result in the error message: ERR increment or decrement would overflow. You could also test setting a key to Long.MAX_VALUE and doing DECRBY -1 to make sure we get the ERR increment or decrement would overflow message (maybe the second scenario is slightly redundant though).
...Test/java/org/apache/geode/redis/internal/executor/string/AbstractDecrByIntegrationTest.java
Outdated
Show resolved
Hide resolved
jhutchison
force-pushed
the
GEODE-9009-finish-decrby
branch
from
26ef01e
to
b4192cc
Compare
|
DUnit test failure is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…RBY command
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.