GEODE-9087: redis docs for HSCAN command #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonbinaryprogrammer
requested review from
jdeppe-pivotal and
sabbey37
as code owners
sabbey37
requested changes
Mar 31, 2021
geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
Outdated
Show resolved
Hide resolved
nonbinaryprogrammer
force-pushed
the
GEODE-9087-docs-SCAN
branch
from
4336ccd
to
44a4a8f
Compare
sabbey37
requested changes
Apr 1, 2021
sabbey37
requested changes
Apr 1, 2021
geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
Outdated
Show resolved
Hide resolved
sabbey37
requested changes
Apr 5, 2021
and fix erb message
sabbey37
requested changes
Apr 7, 2021
geode-docs/tools_modules/geode_apis_compatible_with_redis.html.md.erb
Outdated
Show resolved
Hide resolved
davebarnes97
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
@nonbinaryprogrammer LGTM +1
I should alert you to some massive changes to the README that I submitted for PR 9068 (#6239). LMK if I can help with resolving any merge conflicts. (Better yet, merge first and let the submitters of the massive changes deal with them.)
thanks @davebarnes97, Hutch and I are in communication about it |
sabbey37
approved these changes
Apr 7, 2021
nonbinaryprogrammer
added a commit
to nonbinaryprogrammer/geode
that referenced
this pull request
Apr 7, 2021
(cherry picked from commit 9964531)
nabarunnag
pushed a commit
that referenced
this pull request
Apr 8, 2021
(cherry picked from commit 9964531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.