Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-9052: rename the geode-redis module (#6211) #6253

Conversation

nonbinaryprogrammer
Copy link
Contributor

rename the geode-redis module to geode-apis-compatible-with-redis. this
is so that this name doesn't end up in a customer-facing location that
may cause us to violate Redis's copyright

also adds acceptance test dependency on installDist task. Previously there was not an explicit dependency so tests would fail if they happened to start before the installDist task ran

(cherry picked from commit f82304b)

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

rename the geode-redis module to geode-apis-compatible-with-redis. this
is so that this name doesn't end up in a customer-facing location that
may cause us to violate Redis's copyright

also adds acceptance test dependency on installDist task. Previously there was not an explicit dependency so tests would fail if they happened to start before the installDist task ran

(cherry picked from commit f82304b)
@nonbinaryprogrammer nonbinaryprogrammer added redis Issues related to the geode-for-redis module backport PR related to backporting changes labels Apr 2, 2021
@nonbinaryprogrammer
Copy link
Contributor Author

closed as redundant to: #6264
which was created for ease of resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR related to backporting changes redis Issues related to the geode-for-redis module
Projects
None yet
1 participant