Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport GEODE-9068 Update documents to show removal of unsupported commands #6301

Conversation

jhutchison
Copy link
Contributor

@jhutchison jhutchison commented Apr 9, 2021

(cherry picked from commit 403eae0)

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Copy link
Member

@sabbey37 sabbey37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I randomly glanced at this and it looks like the wrong commit got cherry-picked somehow. I think we meant to cherry-pick this entire commit: 403eae0, but actually cherry-picked just one commit that was included in that squashed commit.

@jhutchison jhutchison force-pushed the backport-GEODE-9068-docs-remove-unsupported-commands branch from 089899a to 86deb2f Compare April 13, 2021 22:17
@jhutchison
Copy link
Contributor Author

I randomly glanced at this and it looks like the wrong commit got cherry-picked somehow. I think we meant to cherry-pick this entire commit: 403eae0, but actually cherry-picked just one commit that was included in that squashed commit.

Thank you so much for catching that- yup, I snagged the wrong commit sha and neglected to look at what actually got pushed up. This should be better. I had to force push since I deleted the old branch and made a new cherry-pick

@jhutchison jhutchison marked this pull request as draft April 14, 2021 16:28
@jhutchison jhutchison force-pushed the backport-GEODE-9068-docs-remove-unsupported-commands branch from 86deb2f to 6a05849 Compare April 21, 2021 18:39
@jhutchison jhutchison marked this pull request as ready for review April 22, 2021 15:18
@sabbey37
Copy link
Member

Going to let @nabarunnag handle the merge as release manager.

…category (apache#6239)

 - make readme commands an unordered list
 - remove text related to unsupported commands in readme
 - alphabetize list of commands in SupportedCommands Junit Test for easy comparison
 - remove references to unsupported commands from docs page
 - remove duplicate server category in RedisCommandType

Co-authored-by: john Hutchison <hutchisonjo@vmware.com>
Co-authored-by: Dave Barnes <daveba@vmware.com>
(cherry picked from commit 403eae0)
@jhutchison jhutchison force-pushed the backport-GEODE-9068-docs-remove-unsupported-commands branch from 6a05849 to f4a49d3 Compare April 22, 2021 20:10
@nabarunnag nabarunnag merged commit 27850ef into apache:support/1.14 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants