GEODE-9138: Moved debug log message and added tests #6417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabarunnag
requested review from
agingade,
DonalEvans,
gesterzhou,
jchen21 and
kirklund
as code owners
DonalEvans
requested changes
Apr 30, 2021
| region.getName(), ((EntryEventImpl) tagHolder).getKey(), tagHolder.getOperation(), | ||
| tagHolder.getEventId().expensiveToString(), evh.getLastSequenceNumber()); | ||
| } | ||
| logger.warn(IGNORING_PREVIOUSLY_SEEN_EVENT, shouldLogPreviouslySeenEvent.getRight(), |
There was a problem hiding this comment.
This logging seems to be identical to the logging just above it, but at warn level rather than debug. Given that this is happening inside a block with if (logger.isDebugEnabled()) this seems like a mistake.
There was a problem hiding this comment.
Removing the warn section may resolve this issue.
Currently if tagHolder=null , it will cause an NPE in the logger.warn message
There was a problem hiding this comment.
That warn is not supposed to be there. I was testing the message and accidentally left that in there. Thanks for finding it.
There was a problem hiding this comment.
@DonalEvans fix implemented
nabarunnag
force-pushed
the
feature/GEODE-9138_logFix
branch
from
28b4e69
to
d8014c8
Compare
DonalEvans
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.