GEODE-3031: Extracting startLocator and startServer from LauncherLifecycleCommands #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YehEmily
force-pushed
the
GEODE-3031
branch
10 times, most recently
from
d3cd0f7
to
9a65436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the JIRA ticket here.
LauncherLifecycleCommands.javawas a huge class that contained commands for starting a server (startServer) and for starting a locator (startLocator). In this PR, these gfsh commands have been extracted and moved to their own classes (StartLocatorCommand.javaandStartServerCommand.java). Then, the other methods associated with these two gfsh commands were refactored and moved to their associated classes or a new sharedStartMemberUtilsclass. Tests associated withLauncherLifecycleCommands.javawere moved toGfshCommandJUnitTest.java,StartServerCommandTest.java,StartServerCommandIntegrationTest.javaStartLocatorCommandTest.java, orStartLocatorCommandIntegrationTest.javabased on what they tested.Testing Progress: precheckin completed successfully
JIRA ticket associated with this PR is referenced in the commit message
PR has been rebased against the latest commit within the target branch
Initial contribution is a single, squashed commit
gradlew buildruns cleanlyWrote/updated unit tests to verify changes