Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-9298: remove concourse deprecation warnings #6510

Merged
merged 4 commits into from May 28, 2021

Conversation

rhoughton-pivot
Copy link
Member

Merging this PR will wipe Concourse history due to pipeline and/or job
name changes.

Thank you for submitting a contribution to Apache Geode.

Merging this PR will wipe Concourse history due to pipeline and/or job
name changes.
@rhoughton-pivot
Copy link
Member Author

@moleske
Copy link
Member

moleske commented May 21, 2021

If you don't want to lose history, there is an old_name field available which will allow you keep the history https://concourse-ci.org/jobs.html#schema.job.old_name

I used it on my current teams concourse when fixing deprecation warnings and it worked well for us. It also exists for resources

@rhoughton-pivot
Copy link
Member Author

If you don't want to lose history, there is an old_name field available which will allow you keep the history https://concourse-ci.org/jobs.html#schema.job.old_name

I used it on my current teams concourse when fixing deprecation warnings and it worked well for us. It also exists for resources

I should add that to keep folk happy.

@rhoughton-pivot rhoughton-pivot marked this pull request as draft May 21, 2021 22:41
@moleske
Copy link
Member

moleske commented May 21, 2021

@rhoughton-pivot also forgot to mention that fly has a command for rename pipeline https://concourse-ci.org/managing-pipelines.html#fly-rename-pipeline to preserve pipeline history if changing the pipeline name. Might be harder to do with automation, but it also should be a one time thing

Copy link
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserving history is not important to me (Jira links to junit results and test artifacts will still work, regardless). but if you do want to go to the trouble of adding old_name everywhere, you might consider flying it manually, rather that committing it that way (since it's really a one-time thing)

@rhoughton-pivot
Copy link
Member Author

On second look, the way we have the jobs templated, we can't use any simple Jinja tricks to modify the names and keep the old ones, and the full rename-effort is not worth it for the sake of history. Any artifacts are uploaded to GCS as needed anyway.

@rhoughton-pivot rhoughton-pivot marked this pull request as ready for review May 22, 2021 02:25
Copy link
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also change _ to - in the three benchmarks jobs names for consistency, and update .asf.yaml as well (even though the copy on develop is not yet the source of truth, it will eventually overwrite what's on master when 1.15.0 is released)

@rhoughton-pivot
Copy link
Member Author

please also change _ to - in the three benchmarks jobs names for consistency, and update .asf.yaml as well (even though the copy on develop is not yet the source of truth, it will eventually overwrite what's on master when 1.15.0 is released)

Done. Please re-review.

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas, poor job history! I knew it, Robert: pages of infinite green and red, of most excellent fancy

Copy link
Contributor

@demery-pivotal demery-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Now I can remove my keyboard's shift key!

@onichols-pivotal onichols-pivotal merged commit 02ffad4 into apache:develop May 28, 2021
@rhoughton-pivot rhoughton-pivot deleted the feature/GEODE-9298 branch May 28, 2021 19:00
pivotal-eshu pushed a commit to pivotal-eshu/geode that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants