New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-9298: remove concourse deprecation warnings #6510
GEODE-9298: remove concourse deprecation warnings #6510
Conversation
Merging this PR will wipe Concourse history due to pipeline and/or job name changes.
Test deployment of the |
If you don't want to lose history, there is an I used it on my current teams concourse when fixing deprecation warnings and it worked well for us. It also exists for resources |
I should add that to keep folk happy. |
@rhoughton-pivot also forgot to mention that fly has a command for rename pipeline https://concourse-ci.org/managing-pipelines.html#fly-rename-pipeline to preserve pipeline history if changing the pipeline name. Might be harder to do with automation, but it also should be a one time thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preserving history is not important to me (Jira links to junit results and test artifacts will still work, regardless). but if you do want to go to the trouble of adding old_name everywhere, you might consider flying it manually, rather that committing it that way (since it's really a one-time thing)
On second look, the way we have the jobs templated, we can't use any simple Jinja tricks to modify the names and keep the old ones, and the full rename-effort is not worth it for the sake of history. Any artifacts are uploaded to GCS as needed anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also change _
to -
in the three benchmarks jobs names for consistency, and update .asf.yaml as well (even though the copy on develop is not yet the source of truth, it will eventually overwrite what's on master when 1.15.0 is released)
Done. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas, poor job history! I knew it, Robert: pages of infinite green and red, of most excellent fancy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Now I can remove my keyboard's shift key!
Merging this PR will wipe Concourse history due to pipeline and/or job
name changes.
Thank you for submitting a contribution to Apache Geode.