[BACKPORT] GEODE-9139 & GEODE-7861 {support/1.13} #6619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GEODE-7861: Improve error reporting in GMSJoinLeave.join() * Fix LocatorDUnitTest.testNoLocator * Changes after the code review * Fix typo (cherry picked from commit 089c1ba)
* GEODE-9139 SSLException in starting up a Locator Preserve the bind-address string specified by the user for cluster communications Also enable use of host names in member identifiers if endpoint validation is enabled. * retain the bind address string or bind address InetAddress in a HostAddress HostAndPort could not be used because there will be a port set but there may not be a bindAddress set. That class requires a host name. * fixed NPE * fixing a few problems with HostAddress * spA * fixed lgtm issue * more lgtm issues fixed * addressing Kamilla's comments * typo * simplify HostAndPort & HostAddress by creating a common superclass to hold their InetSocketAddress. Cache the result of attempting to resolve the host name, as suggested by Bill. * retain the string passed in as the hostname to avoid things like 127.0.0.1 being converted to localhost * added comments about retention of the hostName parameter (cherry picked from commit 55921a4)
…stReconnectAfterMeltdown hang (apache#5192) Modified the test to set the correct locator ports. Modified the teardown code to tell the cache to stop reconnecting. Modified each run to use a temporary working directory so that runs don't leave behind artifacts on disk that can taint subsequent runs. (cherry picked from commit 426d7fd)
echobravopapa
changed the title
|
upgrade test failed. I suggest you re-run it to see if the failure is due to a mere infrastructure problem |
|
this PR has been idle for some months, can it be closed? |
|
closing as abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.