GEODE-9463: Add SerializableRegionRedundancyStatusImpl to accept list #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SerializableRegionRedundancyStatusImpl is stored in RegionOperationStateStore region as
part of OperationState used for REST client.
* OperationState implements Serializable, which causes it to be serialized as a java
Serialiable and also nested SerializableRegionRedundancyStatusImpl.
* Ideally OperationState should implement DSFID to avoid this issue, however, it has been
released already. So we will add SerializableRegionRedundancyStatusImpl to the accept list
to avoid this serialization issue when validate-serializable-objects is set to true.
Co-authored-by: Dan Smith <dasmith@vmware.com>
pivotal-eshu
requested review from
Bill,
DonalEvans,
echobravopapa,
jdeppe-pivotal,
jinmeiliao and
kirklund
as code owners
echobravopapa
approved these changes
Aug 10, 2021
jinmeiliao
approved these changes
Aug 10, 2021
aaronlindsey
approved these changes
Aug 10, 2021
pivotal-eshu
added a commit
to pivotal-eshu/geode
that referenced
this pull request
Aug 11, 2021
…apache#6753) * SerializableRegionRedundancyStatusImpl is stored in RegionOperationStateStore region as part of OperationState used for REST client. * OperationState implements Serializable, which causes it to be serialized as a java Serialiable and also nested SerializableRegionRedundancyStatusImpl. * Ideally OperationState should implement DSFID to avoid this issue, however, it has been released already. So we will add SerializableRegionRedundancyStatusImpl to the accept list to avoid this serialization issue when validate-serializable-objects is set to true. Co-authored-by: Dan Smith <dasmith@vmware.com> (cherry picked from commit 7f98970)
6 tasks
nabarunnag
pushed a commit
that referenced
this pull request
Aug 16, 2021
…#6753) * SerializableRegionRedundancyStatusImpl is stored in RegionOperationStateStore region as part of OperationState used for REST client. * OperationState implements Serializable, which causes it to be serialized as a java Serialiable and also nested SerializableRegionRedundancyStatusImpl. * Ideally OperationState should implement DSFID to avoid this issue, however, it has been released already. So we will add SerializableRegionRedundancyStatusImpl to the accept list to avoid this serialization issue when validate-serializable-objects is set to true. Co-authored-by: Dan Smith <dasmith@vmware.com> (cherry picked from commit 7f98970)
pivotal-eshu
added a commit
that referenced
this pull request
Aug 16, 2021
…#6753) * SerializableRegionRedundancyStatusImpl is stored in RegionOperationStateStore region as part of OperationState used for REST client. * OperationState implements Serializable, which causes it to be serialized as a java Serialiable and also nested SerializableRegionRedundancyStatusImpl. * Ideally OperationState should implement DSFID to avoid this issue, however, it has been released already. So we will add SerializableRegionRedundancyStatusImpl to the accept list to avoid this serialization issue when validate-serializable-objects is set to true. Co-authored-by: Dan Smith <dasmith@vmware.com> (cherry picked from commit 7f98970)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of OperationState used for REST client.
Serialiable and also nested SerializableRegionRedundancyStatusImpl.
released already. So we will add SerializableRegionRedundancyStatusImpl to the accept list
to avoid this serialization issue when validate-serializable-objects is set to true.
Co-authored-by: Dan Smith dasmith@vmware.com
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.