Revert GEODE-4181: Add JUnit 5 Support #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onichols-pivotal
added
the
windows
onichols-pivotal
force-pushed
the
GEODE-4181-revert-junit5
branch
from
78d0aa8
to
ed63f17
Compare
kirklund
approved these changes
Aug 12, 2021
onichols-pivotal
requested review from
dickcav,
mhansonp and
rhoughton-pivot
as code owners
rhoughton-pivot
approved these changes
Aug 12, 2021
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 16, 2021
This reverts commit 9bdfd13.
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 17, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 18, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 19, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 19, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 20, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 23, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 25, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 25, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 26, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 27, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 27, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 30, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 30, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 30, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 30, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Aug 31, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 2, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 2, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 2, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 2, 2021
This reverts commit 9bdfd13.
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 2, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 3, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 14, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 14, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 14, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 14, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 16, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 17, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
Closed
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 20, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 21, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 21, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 22, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
demery-pivotal
added a commit
to demery-pivotal/geode
that referenced
this pull request
Sep 24, 2021
This reverts commit 9bdfd13. Co-authored-by: Dale Emery <demery@vmware.com> Co-authored-by: Kirk Lund <klund@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to large number of Windows CI failures starting after #6740 + #6742 were merged, I want to see if reverting this change makes a difference. If so, we should go through with this revert and try again to make Junit5 work in a new PR with Windows label.