GEODE-9625: Only serialize transaction metadata when grouping enabled. #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-at-work
requested review from
boglesby,
DonalEvans,
gesterzhou,
jchen21,
kirklund and
nabarunnag
as code owners
DonalEvans
approved these changes
Sep 23, 2021
albertogpz
approved these changes
Sep 23, 2021
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
Show resolved
Hide resolved
gesterzhou
reviewed
Sep 23, 2021
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
Outdated
Show resolved
Hide resolved
gesterzhou
reviewed
Sep 23, 2021
| transactionId = event.getTransactionId(); | ||
| this.isLastEventInTransaction = isLastEventInTransaction; | ||
|
|
||
| if (transactionMetadataDisposition != Exclude) { |
There was a problem hiding this comment.
BTW, I did not see toData() and fromData() are changed. Why serialization and replication would save data?
There was a problem hiding this comment.
The disposition is now only set to anything other than Exclude by when TX grouping is enabled. The transactionId is null when transactionMetadataDisposition is Exclude. In toData the transactionId part is only serialized if it isn't null.
jake-at-work
requested review from
agingade,
dschneider-pivotal and
upthewaterspout
as code owners
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
Outdated
Show resolved
Hide resolved
kirklund
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?