GEODE-9674: fix durable client message loss issue in tests. #6923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jinmeiliao
commented
Sep 30, 2021
•
jinmeiliao
commented
- do not try to dispatch residual messages when exception occurred.
- add more tests to verify peer connection, bulk operations and durable clients behavior
- add durable client flag when register interest
- move tests out of upgrade module if does not need older versions to test to avoid conflict in stress tests
jinmeiliao
force-pushed
the
moreTests
branch
7 times, most recently
from
14b8d18
to
f6e265c
Compare
jinmeiliao
requested review from
agingade,
Bill,
echobravopapa,
jdeppe-pivotal,
kirklund and
mhansonp
as code owners
jmelchio
reviewed
Oct 6, 2021
| Region<Object, Object> region = clientCache | ||
| .createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY).create("region"); | ||
|
|
||
| // use InterestResultPolicy.NONE to make sure the old queue is still around |
There was a problem hiding this comment.
Should the durable flag be mentioned here as well?
| logger.warn("Client did not re-authenticate back successfully in " + elapsedTime | ||
| + "ms. Unregister this client proxy."); | ||
| pauseOrUnregisterProxy(expired); | ||
| synchronized (_stopDispatchingLock) { |
There was a problem hiding this comment.
Is this the bit that fixes the race condition?
There was a problem hiding this comment.
mostly by setting "exceptionOccured=true"
| @@ -28,6 +31,7 @@ | |||
| * make sure reset is called after each test to clean things up. | |||
| */ | |||
| public class UpdatableUserAuthInitialize implements AuthInitialize { | |||
| private static Logger logger = LogService.getLogger(); | |||
There was a problem hiding this comment.
This doesn't seem to be used anywhere? Should it stay around?
There was a problem hiding this comment.
Yeah, should remove it.
| @@ -422,7 +422,7 @@ protected void runDispatcher() { | |||
| wait_for_re_auth_start_time = -1; | |||
| } catch (NotAuthorizedException notAuthorized) { | |||
| // behave as if the message is dispatched, remove from the queue | |||
| logger.info("skip delivering message: " + clientMessage, notAuthorized); | |||
| logger.warn("skip delivering message: " + clientMessage, notAuthorized); | |||
There was a problem hiding this comment.
what's the reason for changing log level?
There was a problem hiding this comment.
by a previous review comment when this was introduced. Thought I can address it here.
* do not try to dispatch residual messages when exception occurred. * add more tests to verify peer connection, bulk operations and durable clients behavior * add durable client flag when register interest * move tests out of upgrade module if does not need older versions to test to avoid conflict in stress tests
jinmeiliao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.