GEODE-9413: Enable more native Redis TCL tests for sorted sets #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezoerner
force-pushed
the
feature/GEODE-9413-native-redis-tests-sorted-set
branch
2 times, most recently
from
6f0893b
to
c9b6daf
Compare
ezoerner
force-pushed
the
feature/GEODE-9413-native-redis-tests-sorted-set
branch
from
c9b6daf
to
2dc2474
Compare
ezoerner
requested review from
DonalEvans,
dschneider-pivotal,
jdeppe-pivotal,
kirklund,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
ringles
approved these changes
Oct 8, 2021
DonalEvans
approved these changes
Oct 8, 2021
dschneider-pivotal
approved these changes
Oct 8, 2021
|
the dunit failure is the know flaky issue: https://issues.apache.org/jira/browse/GEODE-1537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enabled more sorted set tests that pass using Geode, but left failing tests still commented out. I also added a comment at the top of each failing test which indicates how the test is failing.
In summary: The ZUNIONSTORE and ZINTERSTORE tests are failing with a WRONGTYPE error when working with regular sets. There is another ZUNIONSTORE test that fails returning 1 instead of 0 when working with an empty set. Other tests are failing due to unknown commands: bzpopmin, bzpopmax, and multi.
TICKETS CREATED: GEODE-9699 GEODE-9700
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?