Revert "GEODE-8876: Statistics not collecting correct value for gets … #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when tra… (apache#6199)" This reverts commit 5dde7d7.
jvarenina
requested review from
boglesby,
DonalEvans,
dschneider-pivotal,
jchen21,
jdeppe-pivotal,
jinmeiliao,
kirklund and
nabarunnag
as code owners
boglesby
approved these changes
Oct 22, 2021
dschneider-pivotal
approved these changes
Oct 22, 2021
dschneider-pivotal
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
when you redo GEODE-8876 I think you should file a new ticket for your changes to the miss stat. GEODE-8876 describes how the get stat is not incremented in a tx. But it says nothing about any problem with the miss stat. I think it would be best not to mix them together in one PR.
kirklund
approved these changes
Oct 22, 2021
jvarenina
added a commit
to Nordix/geode
that referenced
this pull request
Apr 14, 2022
…when tra… (apache#6199)" (apache#7027) This reverts commit 5dde7d7 that caused GEODE-9760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when tra… (#6199)"
This reverts commit 5dde7d7.
Reverted commit introduces the bug that is explained here: https://issues.apache.org/jira/browse/GEODE-9760
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?