New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-9869: Remove geode-for-redis properties from gfsh options #7205
Changes from all commits
37c4265
097e6ad
bb0581d
2c00f83
9c3c09b
bf0413b
e93b144
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,13 +35,13 @@ Use gfsh to start at least one server with a command of the form: | |
start server \ | ||
--name=<serverName> \ | ||
--locators=<locatorPort> \ | ||
--geode-for-redis-port=<geodeForRedisPort> \ | ||
--geode-for-redis-bind-address=<geodeForRedisBindAddress> \ | ||
--geode-for-redis-password=<geodeForRedisPassword> | ||
--J=-Dgemfire.geode-for-redis-enabled=true \ | ||
--J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \ | ||
--J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do these have to be gemfire. or could they be geode.? just since we generally avoid referencing gemfire in geode There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it makes sense since other properties use that format, I just wanted us to think about if that is the right approach or if we're following a pattern that doesn't make sense. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that was discussed and 'gemfire.' won, mostly on 'principle of least surprise' grounds. |
||
``` | ||
|
||
If any of the options `geode-for-redis-bind-address`, `geode-for-redis-password`, or `geode-for-redis-port` | ||
are included, a <%=vars.product_name%> server with <%=vars.product_name%> for Redis will be started. | ||
If the gemfire property `geode-for-redis-enabled`, is set to `true`, a <%=vars.product_name%> | ||
server with <%=vars.product_name%> for Redis will be started. | ||
|
||
Replace `<serverName>` with the name of your server. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,11 +34,12 @@ Once the locator has started, start at least one server with a command of the fo | |
gfsh> start server \ | ||
--name=<serverName> \ | ||
--locators=localhost[<locatorPort>] \ | ||
--geode-for-redis-port=<geodeForRedisPort> \ | ||
--geode-for-redis-bind-address=<geodeForRedisBindAddress> | ||
--J=-Dgemfire.geode-for-redis-enabled=true \ | ||
--J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \ | ||
--J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress> | ||
``` | ||
|
||
If any of the options `geode-for-redis-bind-address`, `geode-for-redis-username`, or `geode-for-redis-port` are included, a Geode server with Geode for Redis will be started. | ||
If the option `geode-for-redis-enabled` is set to `true`, a Geode server with Geode for Redis will be started. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. option once again There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, this needs a fix. Must be explicitly enabled now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Except we're getting rid of the Redis README.md now, I think. |
||
|
||
- Replace `<serverName>` with the name of your server. | ||
|
||
|
@@ -105,9 +106,10 @@ The following gfsh command will configure a `SimpleSecurityManager`: | |
gfsh> start server \ | ||
--name=<serverName> \ | ||
--locators=<locatorPort> \ | ||
--geode-for-redis-port=<geodeForRedisPort> \ | ||
--geode-for-redis-bind-address=<geodeForRedisBindAddress> \ | ||
--geode-for-redis-username=<geodeForRedisUsername> \ | ||
--J=-Dgemfire.geode-for-redis-enabled=true \ | ||
--J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \ | ||
--J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress> \ | ||
--J=-Dgemfire.geode-for-redis-username=<geodeForRedisUsername> \ | ||
--J=-Dgemfire.security-manager=org.apache.geode.examples.SimpleSecurityManager | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this one but not the bind address and username?