GEODE-10000: Avoid gfsh stop gateway sender error when stopped a seco…

[albertogpz]

…nd time

The thread executor used by the command to stop the gateway senders in parallel on every server was being shutdown after the command finished. That provoked that the executor could not be used in subsequent executions of the command returning the following error:

Error while processing command <stop gateway-sender --id=sender1> Reason : Task java.util.concurrent.FutureTask@513d30f9 rejected from java.util.concurrent.ThreadPoolExecutor@85189b9[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 2]

The fix consists of removing the shutdown of the executor after the command has been executed.

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[mhansonp]

I don't usually request comments, but it would have been handy to have some here or in the bug to explain what you decided to do in light of the problem with your change. It looks like you decided to back it out and add a test that would catch the problem you created (though backed out).

[albertogpz]

I don't usually request comments, but it would have been handy to have some here or in the bug to explain what you decided to do in light of the problem with your change. It looks like you decided to back it out and add a test that would catch the problem you created (though backed out).

Sorry for not adding comments to the fix. I assumed it would be easy to understand by looking at the change in code and at the test case but I agree it should have been better to add comments.